[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] qdev'ify dp8393x
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] qdev'ify dp8393x |
Date: |
Thu, 01 Jan 2015 18:32:19 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
Hi Andreas,
Thank you for your comments.
You're right: I will change the subject and distinguish the
instance_init and realize.
dp83932_init() is used in a single place, so as you propose I will
inline it and remove the function definition.
Regards,
Laurent
Le 01/01/2015 17:15, Andreas Färber a écrit :
> Hi Laurent,
>
> Am 29.12.2014 um 01:39 schrieb Laurent Vivier:
>> Signed-off-by: Laurent Vivier <address@hidden>
>> ---
>> hw/mips/mips_jazz.c | 2 +-
>> hw/net/dp8393x.c | 182
>> +++++++++++++++++++++++++++++++----------------
>> include/hw/net/dp8393x.h | 1 -
>> 3 files changed, 121 insertions(+), 64 deletions(-)
>
> Thanks for doing this cleanup! "QOM'ify" would be more correct
> (subject). Patch looks good except for one nit: Can you distinguish
> between instance_init and realize function rather than using the old
> SysBusDeviceClass::init?
>
> Also, can dp83932_init() be inlined in the call site, or is it used in
> multiple places?
>
> Regards,
> Andreas
>
signature.asc
Description: OpenPGP digital signature