[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/11] cpu_ldst.h: Allow NB_MMU_MODES to be 7
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 01/11] cpu_ldst.h: Allow NB_MMU_MODES to be 7 |
Date: |
Sat, 24 Jan 2015 01:05:08 +0000 |
On 23 January 2015 at 20:16, Greg Bellows <address@hidden> wrote:
> On Fri, Jan 23, 2015 at 12:20 PM, Peter Maydell
> <address@hidden> wrote:
>> Support guest CPUs which need 7 MMU index values.
>> Add a comment about what would be required to raise the limit
>> further (trivial for 8, TCG backend rework for 9 or more).
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>> include/exec/cpu_ldst.h | 28 +++++++++++++++++++++++++---
>> 1 file changed, 25 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h
>> index 0e825ea..fa5ea63 100644
>> --- a/include/exec/cpu_ldst.h
>> +++ b/include/exec/cpu_ldst.h
>> @@ -244,9 +244,31 @@ uint64_t helper_ldq_cmmu(CPUArchState *env,
>> target_ulong addr, int mmu_idx);
>> #undef MEMSUFFIX
>> #endif /* (NB_MMU_MODES >= 6) */
>>
>> -#if (NB_MMU_MODES > 6)
>> -#error "NB_MMU_MODES > 6 is not supported for now"
>> -#endif /* (NB_MMU_MODES > 6) */
>> +#if (NB_MMU_MODES >= 7) && defined(MMU_MODE6_SUFFIX)
>> +
>> +#define CPU_MMU_INDEX 6
>> +#define MEMSUFFIX MMU_MODE5_SUFFIX
>
> Should this be MMU_MODE6_SUFFIX?
Yes, good catch (we don't notice since we don't define
the MMU_MODE*_SUFFIX anyway).
-- PMM
- [Qemu-devel] [PATCH 00/11] target-arm: handle mmu_idx/translation regimes properly, Peter Maydell, 2015/01/23
- [Qemu-devel] [PATCH 08/11] target-arm: Pass mmu_idx to get_phys_addr(), Peter Maydell, 2015/01/23
- [Qemu-devel] [PATCH 10/11] target-arm: Reindent ancient page-table-walk code, Peter Maydell, 2015/01/23
- [Qemu-devel] [PATCH 07/11] target-arm: Split AArch64 cases out of ats_write(), Peter Maydell, 2015/01/23
- [Qemu-devel] [PATCH 01/11] cpu_ldst.h: Allow NB_MMU_MODES to be 7, Peter Maydell, 2015/01/23
- [Qemu-devel] [PATCH 09/11] target-arm: Use mmu_idx in get_phys_addr(), Peter Maydell, 2015/01/23
- Re: [Qemu-devel] [PATCH 09/11] target-arm: Use mmu_idx in get_phys_addr(), Greg Bellows, 2015/01/28
[Qemu-devel] [PATCH 05/11] target-arm: Use correct mmu_idx for unprivileged loads and stores, Peter Maydell, 2015/01/23