Re: [Qemu-devel] [PATCH 01/50] blockdev: Allow creation of BDS trees without BB

[Max Reitz]

On 2015-01-27 at 13:22, Eric Blake wrote:
> On 01/26/2015 09:02 AM, Max Reitz wrote:
> > If the "id" field is missing from the options given to blockdev-add,
> > just omit the BlockBackend and create the BlockDriverState tree alone.
> >
> > Signed-off-by: Max Reitz <address@hidden>
> > ---
> >   blockdev.c                 | 38 +++++++++++++++++++++++++-------------
> >   tests/qemu-iotests/087     | 20 --------------------
> >   tests/qemu-iotests/087.out | 12 ------------
> >   3 files changed, 25 insertions(+), 45 deletions(-)
> I'd feel more comfortable if this patch also touched
> qapi/block-core.json to mention the change in policy on
> BlockdevOptionsBase.

Will do.

> Also, should 'node-name' be mandatory when
> omitting 'id'?

Seems good to me. Not specifying a node-name doesn't make a whole lot of 
sense, except for when you really badly want qemu to create useless 
structures in memory.

Max