qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence


From: Pavel Dovgaluk
Subject: Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence
Date: Mon, 2 Feb 2015 15:42:38 +0300

> From: Paolo Bonzini [mailto:address@hidden
> On 02/02/2015 13:28, Pavel Dovgaluk wrote:
> >>> > >                              cpu->exception_index = EXCP_INTERRUPT;
> >>> > >                              next_tb = 0;
> >>> > > +                            qemu_notify_event();
> >> >
> >> > Why is this needed?
> > It is needed to wake up iothread in replay mode.
> > Otherwise it waits for additional time and replay becomes too slow.
> 
> What event (something from a timerlist?) is ready, that has not been
> notified to the iothread yet?  qemu_notify_event() should never be
> needed in common case.  It's probably missing somewhere else.

I think in this case there are no events at all - just reading timers values
that were made while recording.
We have to replay these reads by waking iothread.

Pavel Dovgalyuk




reply via email to

[Prev in Thread] Current Thread [Next in Thread]