Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

[Paolo Bonzini]

On 02/02/2015 13:42, Pavel Dovgaluk wrote:
>> From: Paolo Bonzini [mailto:address@hidden
>> On 02/02/2015 13:28, Pavel Dovgaluk wrote:
>>>>>>>                              cpu->exception_index = EXCP_INTERRUPT;
>>>>>>>                              next_tb = 0;
>>>>>>> +                            qemu_notify_event();
>>>>>
>>>>> Why is this needed?
>>> It is needed to wake up iothread in replay mode.
>>> Otherwise it waits for additional time and replay becomes too slow.
>>
>> What event (something from a timerlist?) is ready, that has not been
>> notified to the iothread yet?  qemu_notify_event() should never be
>> needed in common case.  It's probably missing somewhere else.
> 
> I think in this case there are no events at all - just reading timers values
> that were made while recording.
> We have to replay these reads by waking iothread.

I think the right place for this is in replay_read_next_clock then.

Paolo