[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] softmmu: support up to 12 MMU modes
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/3] softmmu: support up to 12 MMU modes |
|
Date: |
Fri, 20 Feb 2015 11:51:03 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/20/2015 09:57 AM, Paolo Bonzini wrote:
> + * TCG will have to generate an operand as large as the distance between
> + * tlb_table[0][0] and the tlb_table[NB_MMU_MODES - 1][0].addend. For
Nit: the distance is from the start of env, i.e.
offsetof(CPUArchState, tlb_table[mem_index][0].addend)
not from the start of the table. Not that this particularly invalidates the
rest of your reasoning, but the start of the tlb_table is usually at a
non-trivial (though not huge) offset from the start of CPUArchState.
Otherwise, it looks good.
r~