[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/10] s390x/kvm: helper to set the SIGP status in S
From: |
Jens Freimann |
Subject: |
[Qemu-devel] [PATCH 04/10] s390x/kvm: helper to set the SIGP status in SigpInfo |
Date: |
Tue, 24 Feb 2015 14:15:25 +0100 |
From: David Hildenbrand <address@hidden>
Whenever we set the SIGP status in the status register, we have to wipe out
the lower 4 bytes and keep the higher 4 bytes. Also the condition code will
always be set to STATUS_STORED.
Let's introduce the wrapper for SigpInfo, as this will avoid most duplicate
code in the future.
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Jens Freimann <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
target-s390x/kvm.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
index 1f4a4b1..fb0ce6d 100644
--- a/target-s390x/kvm.c
+++ b/target-s390x/kvm.c
@@ -1105,6 +1105,13 @@ typedef struct SigpInfo {
uint64_t *status_reg;
} SigpInfo;
+static void set_sigp_status(SigpInfo *si, uint64_t status)
+{
+ *si->status_reg &= 0xffffffff00000000ULL;
+ *si->status_reg |= status;
+ si->cc = SIGP_CC_STATUS_STORED;
+}
+
static void sigp_start(void *arg)
{
SigpInfo *si = arg;
@@ -1189,9 +1196,7 @@ static int handle_sigp_single_dst(S390CPU *dst_cpu,
uint8_t order,
break;
default:
DPRINTF("KVM: unknown SIGP: 0x%x\n", order);
- *status_reg &= 0xffffffff00000000ULL;
- *status_reg |= SIGP_STAT_INVALID_ORDER;
- si.cc = SIGP_CC_STATUS_STORED;
+ set_sigp_status(&si, SIGP_STAT_INVALID_ORDER);
}
return si.cc;
--
2.1.4
- [Qemu-devel] [PATCH 00/10] s390x: move sigp handling to user space, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 05/10] s390x/kvm: trace all SIGP orders, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 10/10] s390x/kvm: enable the new SIGP handling in user space, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 03/10] s390x/kvm: pass the SIGP instruction parameter to the SIGP handler, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 04/10] s390x/kvm: helper to set the SIGP status in SigpInfo,
Jens Freimann <=
- [Qemu-devel] [PATCH 01/10] s390x: introduce defines for SIGP condition codes, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 09/10] s390x/kvm: deliver SIGP RESTART directly if stopped, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 06/10] s390x/kvm: implement handling of new SIGP orders, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 07/10] s390x/kvm: SIGP START is only applicable when STOPPED, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 08/10] s390x: add function to deliver restart irqs, Jens Freimann, 2015/02/24
- [Qemu-devel] [PATCH 02/10] s390x/kvm: more details for SIGP handler with one destination vcpu, Jens Freimann, 2015/02/24