[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] target-i386: Rename optimize_flags_init()
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] target-i386: Rename optimize_flags_init() |
Date: |
Thu, 5 Mar 2015 17:31:39 +0100 |
On Thu, 5 Mar 2015 12:38:48 -0300
Eduardo Habkost <address@hidden> wrote:
> Rename the function so that the reason for its existence is clearer: it
> does x86-specific initialization of TCG structures.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> target-i386/cpu.c | 2 +-
> target-i386/cpu.h | 2 +-
> target-i386/translate.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 50907d0..b4e70d3 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -2883,7 +2883,7 @@ static void x86_cpu_initfn(Object *obj)
> /* init various static tables used in TCG mode */
> if (tcg_enabled() && !inited) {
> inited = 1;
> - optimize_flags_init();
> + tcg_x86_init();
> }
how about moving 'inited' handling inside of tcg_x86_init() along with renaming?
> }
>
> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> index 0638d24..52b460a 100644
> --- a/target-i386/cpu.h
> +++ b/target-i386/cpu.h
> @@ -1228,7 +1228,7 @@ static inline target_long lshift(target_long x, int n)
> #define ST1 ST(1)
>
> /* translate.c */
> -void optimize_flags_init(void);
> +void tcg_x86_init(void);
>
> #include "exec/cpu-all.h"
> #include "svm.h"
> diff --git a/target-i386/translate.c b/target-i386/translate.c
> index 094cec0..f19f20f 100644
> --- a/target-i386/translate.c
> +++ b/target-i386/translate.c
> @@ -7852,7 +7852,7 @@ static target_ulong disas_insn(CPUX86State *env,
> DisasContext *s,
> return s->pc;
> }
>
> -void optimize_flags_init(void)
> +void tcg_x86_init(void)
> {
> static const char reg_names[CPU_NB_REGS][4] = {
> #ifdef TARGET_X86_64
- [Qemu-devel] [PATCH 0/6] target-i386: Remove side-effects from X86CPU::instance_init, Eduardo Habkost, 2015/03/05
- [Qemu-devel] [PATCH 2/6] cpu: Initialize breakpoint/watchpoint lists on cpu_common_initfn(), Eduardo Habkost, 2015/03/05
- [Qemu-devel] [PATCH 3/6] cpu: Reorder cpu->as and cpu->thread_id initialization, Eduardo Habkost, 2015/03/05
- [Qemu-devel] [PATCH 5/6] target-i386: Move TCG initialization to realize time, Eduardo Habkost, 2015/03/05
- [Qemu-devel] [PATCH 4/6] target-i386: Rename optimize_flags_init(), Eduardo Habkost, 2015/03/05
- Re: [Qemu-devel] [PATCH 4/6] target-i386: Rename optimize_flags_init(),
Igor Mammedov <=
- [Qemu-devel] [PATCH 6/6] target-i386: Call cpu_exec_init() on realize, Eduardo Habkost, 2015/03/05
- [Qemu-devel] [PATCH 1/6] cpu: No need to zero-initialize numa_node, Eduardo Habkost, 2015/03/05
- Re: [Qemu-devel] [PATCH 0/6] target-i386: Remove side-effects from X86CPU::instance_init, Eduardo Habkost, 2015/03/05