Re: [Qemu-devel] [PATCH 0/6] fw-cfg: documentation, cleanup, and proposed feature

[Patchew Tool]

This series passed Patchew automatic testing, but there are some warnings.

Find the log fragments below, or open the following URL to see the full log:

http://qemu.patchew.org/testing/log/<address@hidden>

----------8<---------

docker run --net=none -v 
/var/tmp/patchew-tester/tmpBjk7tO:/var/tmp/patchew-test patchew:fedora-20 
timeout 3600 /var/tmp/patchew-test/qemu-devel.sh /var/tmp/patchew-test

*** Testing 'coding style check' ***

Checking 0001-fw_cfg--add-documentation-file--docs-specs-fw_cfg-txt-.patch
total: 0 errors, 0 warnings, 167 lines checked

0001-fw_cfg--add-documentation-file--docs-specs-fw_cfg-txt-.patch has no 
obvious style problems and is ready for submission.

Checking 0002-fw_cfg--remove-support-for-guest-side-data-writes.patch
command failed with exit code 0
$@
ERROR: code indent should never use tabs
#203: FILE: include/hw/nvram/fw_cfg.h:43:
+#define FW_CFG_WRITE_CHANNEL    0x4000^I/* reserved (not implemented) */$

total: 1 errors, 0 warnings, 172 lines checked

0002-fw_cfg--remove-support-for-guest-side-data-writes.patch has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking 
0003-fw_cfg--assertion-to-detect-memory-leak-when-adding-new-data-blob.patch
total: 0 errors, 0 warnings, 7 lines checked

0003-fw_cfg--assertion-to-detect-memory-leak-when-adding-new-data-blob.patch 
has no obvious style problems and is ready for submission.

Checking 0004-fw_cfg--exit-with-error-when-dupe-fw_cfg-file-name-inserted.patch
total: 0 errors, 0 warnings, 24 lines checked

0004-fw_cfg--exit-with-error-when-dupe-fw_cfg-file-name-inserted.patch has no 
obvious style problems and is ready for submission.

Checking 0005-fw_cfg--insert-fw_cfg-file-blobs-via-qemu-cmdline.patch
total: 0 errors, 0 warnings, 143 lines checked

0005-fw_cfg--insert-fw_cfg-file-blobs-via-qemu-cmdline.patch has no obvious 
style problems and is ready for submission.

Checking 0006-qga--RFC--guest-side-retrieval-of-fw_cfg-file.patch
command failed with exit code 0
$@
ERROR: do not use C99 // comments
#99: FILE: qga/get-fwcfg.c:44:
+__attribute__((optimize("O0"))) //FIXME: "gcc -O2" wrongfully optimizes "if"!!!

ERROR: do not use C99 // comments
#130: FILE: qga/get-fwcfg.c:75:
+        //FIXME: why does gcc -O2 optimize away the whole if {} block below?!?

total: 2 errors, 0 warnings, 133 lines checked

0006-qga--RFC--guest-side-retrieval-of-fw_cfg-file.patch has style problems, 
please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.


*** Testing 'configure' ***

Install prefix    /usr/local
BIOS directory    /usr/local/share/qemu
binary directory  /usr/local/bin
library directory /usr/local/lib
module directory  /usr/local/lib/qemu
libexec directory /usr/local/libexec