[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] fw_cfg: remove support for guest-side data
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 2/6] fw_cfg: remove support for guest-side data writes |
Date: |
Tue, 17 Mar 2015 08:46:58 +0100 |
Hi,
> Another possibility is to leave the write_ops in there, but turn them
> into no-ops.
That is the safe choice. Just have a write function with /* nothing,
write support removed in qemu 2.4+ */. That is basically the same we
have today (writes are ignored), but a bit more efficient because we
kill the unused infrastructure to register writable fw_cfg entries and
thus don't have to do the lookup just to figure there is no match ;)
cheers,
Gerd
- Re: [Qemu-devel] [PATCH 1/6] fw_cfg: add documentation file (docs/specs/fw_cfg.txt), (continued)
- [Qemu-devel] [PATCH 4/6] fw_cfg: exit with error when dupe fw_cfg file name inserted, Gabriel L. Somlo, 2015/03/16
- [Qemu-devel] [PATCH 5/6] fw_cfg: insert fw_cfg file blobs via qemu cmdline, Gabriel L. Somlo, 2015/03/16
- [Qemu-devel] [PATCH 6/6] qga: RFC: guest-side retrieval of fw_cfg file, Gabriel L. Somlo, 2015/03/16
- [Qemu-devel] [PATCH 3/6] fw_cfg: assertion to detect memory leak when adding new data blob, Gabriel L. Somlo, 2015/03/16
- [Qemu-devel] [PATCH 2/6] fw_cfg: remove support for guest-side data writes, Gabriel L. Somlo, 2015/03/16
- Re: [Qemu-devel] [PATCH 0/6] fw-cfg: documentation, cleanup, and proposed feature, Patchew Tool, 2015/03/16