[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in sc
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in schema json |
Date: |
Tue, 31 Mar 2015 22:09:30 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Am 24.03.2015 um 21:03 hat Eric Blake geschrieben:
>> From: Fam Zheng <address@hidden>
>>
>> In the near term, we will use it for a sensible-looking
>> 'gen':false inside command declarations, instead of the
>> current ugly 'gen':'no'.
>>
>> In the long term, it will allow conversion from shorthand
>> with defaults mentioned only in side-band documentation:
>> 'data':{'*flag':'bool', '*string':'str'}
>> into an explicit default value documentation, as in:
>> 'data':{'flag':{'type':'bool', 'optional':true, 'default':true},
>> 'string':{'type':'str', 'optional':true, 'default':null}}
>
> FWIW, I don't think that's a very friendly syntax for humans, it's a bit
> verbose. But that's no reason not to allow true/false/null, of course.
Here's my current thinking.
Longhand:
# mandatory
'name': { 'type': 'str' }
# optional, with a default
'flag': { 'type': 'bool', 'default': true }
# optional, no default
'string': { 'type': 'str', 'default': null }
Presence of 'default' implies optional.
Equivalent shorthand, if any:
'name': 'str'
'*string': 'str'
[...]
- Re: [Qemu-devel] [PATCH v5 13/28] qapi: Add some expr tests, (continued)
- [Qemu-devel] [PATCH v5 11/28] qapi: Rename anonymous union type in test, Eric Blake, 2015/03/24
- [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in schema json, Eric Blake, 2015/03/24
- [Qemu-devel] [PATCH v5 05/28] qapi: Better error messages for bad enums, Eric Blake, 2015/03/24
- [Qemu-devel] [PATCH v5 15/28] qapi: Add tests of redefined expressions, Eric Blake, 2015/03/24
- [Qemu-devel] [PATCH v5 14/28] qapi: Better error messages for bad expressions, Eric Blake, 2015/03/24
- [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests, Eric Blake, 2015/03/24