[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/9] qapi: Turn generators' mandatory option -i
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 6/9] qapi: Turn generators' mandatory option -i into an argument |
Date: |
Thu, 14 May 2015 09:22:28 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 05/11/2015 01:24 AM, Markus Armbruster wrote:
> Mandatory option is silly, and the error handling is missing: the
> programs crash when -i isn't supplied. Make it an argument, and check
> it properly.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> Makefile | 14 +++++++-------
> docs/qapi-code-gen.txt | 10 +++++-----
> scripts/qapi.py | 12 +++++-------
> tests/Makefile | 8 ++++----
> 4 files changed, 21 insertions(+), 23 deletions(-)
>
> @@ -999,8 +996,9 @@ def parse_command_line(extra_options = "",
> extra_long_options = []):
> do_c = True
> do_h = True
>
> - if len(args) != 0:
> - print >>sys.stderr, "%s: too many arguments"% sys.argv[0]
> + if len(args) != 1:
> + print >>sys.stderr, "%s: need exactly one argument" % sys.argv[0]
Hmm, might be affected by resolution of my review comments on 5/9; but
shouldn't affect the review.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/9] qapi: Mostly generator cleanups, Markus Armbruster, 2015/05/11
- [Qemu-devel] [PATCH 8/9] qapi: Drop pointless flush() before close(), Markus Armbruster, 2015/05/11
- [Qemu-devel] [PATCH 5/9] qapi: Fix generators to report command line errors decently, Markus Armbruster, 2015/05/11
- [Qemu-devel] [PATCH 1/9] tests: Add missing dependencies on $(qapi-py), Markus Armbruster, 2015/05/11
- [Qemu-devel] [PATCH 3/9] qapi: qapi-commands.py option --type is unused, drop it, Markus Armbruster, 2015/05/11
- [Qemu-devel] [PATCH 9/9] qapi: Inline gen_command_decl_prologue(), gen_command_def_prologue(), Markus Armbruster, 2015/05/11
- [Qemu-devel] [PATCH 4/9] qapi: Factor parse_command_line() out of the generators, Markus Armbruster, 2015/05/11
- [Qemu-devel] [PATCH 6/9] qapi: Turn generators' mandatory option -i into an argument, Markus Armbruster, 2015/05/11
- Re: [Qemu-devel] [PATCH 6/9] qapi: Turn generators' mandatory option -i into an argument,
Eric Blake <=
- [Qemu-devel] [PATCH 7/9] qapi: Factor open_output(), close_output() out of generators, Markus Armbruster, 2015/05/11
- [Qemu-devel] [PATCH 2/9] qapi: qapi-event.py option -b does nothing, drop it, Markus Armbruster, 2015/05/11
- Re: [Qemu-devel] [PATCH 0/9] qapi: Mostly generator cleanups, Eric Blake, 2015/05/14