Re: [Qemu-devel] [PATCH 5/9] qapi: Fix generators to report command line errors decently

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 05/11/2015 01:24 AM, Markus Armbruster wrote:
>> Report to stderr, prefix with the program name.  Also reject
>> extra arguments.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>> ---
>>  scripts/qapi.py | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>> 
>
>> @@ -999,4 +999,8 @@ def parse_command_line(extra_options = "", 
>> extra_long_options = []):
>>          do_c = True
>>          do_h = True
>>  
>> +    if len(args) != 0:
>> +        print >>sys.stderr, "%s: too many arguments"% sys.argv[0]
>
> Spacing on both sides of %?  Or even:
>
> print >>sys.stderr, sys.argv[0] + ": too many arguments"
>
> but trivial enough to keep R-b whatever you decide.

Spacing tidied up, thanks!