Re: [Qemu-devel] [PATCH 4/9] runstate: create runstate_index function

[Eric Blake]

On 05/18/2015 03:58 AM, Dr. David Alan Gilbert wrote:
> * Juan Quintela (address@hidden) wrote:
>> Given a string state, we need a way to get the RunState for that string.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>>  include/sysemu/sysemu.h |  1 +
>>  vl.c                    | 13 +++++++++++++
>>  2 files changed, 14 insertions(+)
>>

>>
>> +RunState runstate_index(char *str)
>> +{
>> +    RunState i = 0;
>> +
>> +    while (i != RUN_STATE_MAX) {
>> +        if (strcmp(str, RunState_lookup[i]) == 0) {
>> +            return i;
>> +        }
>> +        i++;
>> +    }
>> +    return -1;
> 
> It doesn't seem right to return -1 for the value of an enum
> (which is otherwise used as an index into an array of strings).
> 
> Make it return a bool and pass the RunState* as a parameter ?

Why open-code this, when we already have qapi_enum_parse() in
qapi/qapi-util.c?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature