Re: [Qemu-devel] [PATCH v6 0/4] remove icc bus/bridge

[Eduardo Habkost]

Paolo, Michael, Andreas: I plan to apply this on the x86 tree once it
gets reviewed. If you don't object, can I get Acked-by lines from you?

On Wed, May 20, 2015 at 10:40:45AM +0800, Zhu Guihua wrote:
> ICC Bus was used for providing a hotpluggable bus for APIC and CPU,
> but now we use HotplugHandler to make hotplug. So ICC Bus is
> unnecessary.
> 
> This code has passed the new pc-cpu-test.
> And I have tested with kvm along with kernel_irqchip=on/off,
> it works fine.
> 
> This patch series is rebased on Eduardo's x86 tree.
> https://github.com/ehabkost/qemu.git
> 
> v6:
>  -reword commit message
>  -drop NULL check for APIC device
>  -use C cast instead of QOM cast
> 
> v5:
>  -convert DEVICE() casts to C casts
>  -use a local variable instead of doing the cast inline twice
>  -drop to set cpu's parent bus
>  -rename patch 3's subject
>  -fix a bug about setting cpu's apic base
> 
> v4:
>  -add wrapper to get root memory region from address space
>  -set cpu apic base's default value in x86_cpu_apic_create()
>  -drop NULL check for cpu apic_state
>  -put drop of the unused files about icc_bus into a seprate patch
>  -put DEVICE() casts into a seprate patch
> 
> v3:
>  -replace init apic by object_new()
>  -add reset apic at the time of CPU reset
> 
> Chen Fan (2):
>   apic: map APIC's MMIO region at each CPU's address space
>   cpu/apic: drop icc bus/bridge
> 
> Zhu Guihua (2):
>   apic: convert ->busdev.qdev casts to C casts
>   icc_bus: drop the unused files
> 
>  default-configs/i386-softmmu.mak   |   1 -
>  default-configs/x86_64-softmmu.mak |   1 -
>  exec.c                             |   5 ++
>  hw/cpu/Makefile.objs               |   1 -
>  hw/cpu/icc_bus.c                   | 118 
> -------------------------------------
>  hw/i386/pc.c                       |  26 ++------
>  hw/i386/pc_piix.c                  |   9 +--
>  hw/i386/pc_q35.c                   |   9 +--
>  hw/intc/apic.c                     |   9 ++-
>  hw/intc/apic_common.c              |  19 +++---
>  include/exec/memory.h              |   5 ++
>  include/hw/cpu/icc_bus.h           |  82 --------------------------
>  include/hw/i386/apic_internal.h    |   7 ++-
>  include/hw/i386/pc.h               |   2 +-
>  target-i386/cpu.c                  |  16 ++---
>  15 files changed, 45 insertions(+), 265 deletions(-)
>  delete mode 100644 hw/cpu/icc_bus.c
>  delete mode 100644 include/hw/cpu/icc_bus.h
> 
> -- 
> 1.9.3
> 

-- 
Eduardo