[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/3] target-mips: Misaligned memory accesses
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 3/3] target-mips: Misaligned memory accesses for MSA |
|
Date: |
Thu, 21 May 2015 09:16:40 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 05/21/2015 02:47 AM, Yongbok Kim wrote:
> On 20/05/2015 18:25, Richard Henderson wrote:
>
>>
>>> + int i; \
>>> + for (i = 0; i < DF_ELEMENTS(DF); i++) { \
>>> + wx.TYPE[i] = LD_INSN(env, addr + (i << DF), ##__VA_ARGS__); \
>>
>> Why the varargs? They're the same all the time.
>
> No, they aren't. we still need to support linux user mode which don't have
> any extra argument.
>
> MSA_LD_DF(DF_BYTE, b, helper_ret_ldub_mmu, \
> make_memop_idx(MO_UNALN, cpu_mmu_index(env)), GETRA())
>
> VS.
>
> MSA_LD_DF(DF_BYTE, b, cpu_ldub_data)
Ah, I'd missed that. Thanks,
r~