Re: [Qemu-devel] [PATCH] configure: Check for libfdt version 1.4.0

[David Gibson]

On Mon, May 25, 2015 at 01:30:11PM +0100, Peter Maydell wrote:
> On 25 May 2015 at 02:35, David Gibson <address@hidden> wrote:
> > On Mon, May 18, 2015 at 09:43:21AM +0200, Thomas Huth wrote:
> >> Some recent patches require functions from libfdt version 1.4.0,
> >> so we should check for this version during the configure step
> >> already. Unfortunately, there does not seem to be a proper #define
> >> for the version number in the libfdt headers. So alternatively, we
> >> check for the availability of the fdtXX_t types instead which have
> >> just been introduced with version 1.4.0.
> >
> > Um.. I'm confused by this.  As far as I can recall the fdtXX_t types
> > have been in libfdt since.. well, forever, basically.
> 
> There's no such typedef in the libfdt that QEMU is currently
> using (which I think is 1.3.0). It looks like they were added
> in this commit:
> https://git.kernel.org/cgit/utils/dtc/dtc.git/commit/libfdt/libfdt_env.h?id=feafcd972cb744750a65728440c99526e6199a6d
> in early 2013.

Ah, duh, I was mixing up the fdtXX_t _types_ which were introduced
with sparse annotations with the fdtXX_to_cpu functions/macros which
have been around since forever.

Still, I think looking at the actual exported functions is a better
idea than looking at the types - which I see Thomas has already done
in his latest spin.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

pgpHBxaGKPMLQ.pgp
Description: PGP signature