[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 15/23] target-i386: use memory API to impleme
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 15/23] target-i386: use memory API to implement SMRAM |
Date: |
Thu, 04 Jun 2015 10:05:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/06/2015 09:19, Peter Crosthwaite wrote:
> > Remove cpu_smm_register and cpu_smm_update. Instead, each CPU
> > address space gets an extra region which is an alias of
> > /machine/smram. This extra region is enabled or disabled
> > as the CPU enters/exits SMM.
>
> Why is the connectivity from machine->CPU made via a predetermined
> canon path? This has come up for me a few times out-of-tree and I have
> managed it via links. Can the machine create the smram bus as a
> MemoryRegion and in a loop pass it to each CPU via a MemoryRegion *
> link?
I did it this way because there's only one SMRAM---it's basically a part
of address_space_memory that's usually hidden, and there's only one
address_space_memory.
Also, KVM would not support separate per-CPU SMRAMs, even if they
existed on real hardware, so a single per-machine object made more sense
to me.
Paolo
- Re: [Qemu-devel] [PATCH v2 12/23] vl: run "late" notifiers immediately, (continued)
- [Qemu-devel] [PATCH v2 14/23] hw/i386: add a separate region that tracks the SMRAME bit, Paolo Bonzini, 2015/06/03
- [Qemu-devel] [PATCH v2 16/23] hw/i386: remove smram_update, Paolo Bonzini, 2015/06/03
- [Qemu-devel] [PATCH v2 15/23] target-i386: use memory API to implement SMRAM, Paolo Bonzini, 2015/06/03
- [Qemu-devel] [PATCH v2 17/23] q35: implement high SMRAM, Paolo Bonzini, 2015/06/03
- [Qemu-devel] [PATCH v2 18/23] q35: fix ESMRAMC default, Paolo Bonzini, 2015/06/03
- [Qemu-devel] [PATCH v2 20/23] q35: implement SMRAM.D_LCK, Paolo Bonzini, 2015/06/03
- [Qemu-devel] [PATCH v2 19/23] q35: add config space wmask for SMRAM and ESMRAMC, Paolo Bonzini, 2015/06/03
- [Qemu-devel] [PATCH v2 21/23] q35: add test for SMRAM.D_LCK, Paolo Bonzini, 2015/06/03