Re: [Qemu-devel] [PATCH 00/10 v12] tilegx: Firstly add tilegx target for linux-user

[Chen Gang]

On 06/19/2015 06:02 AM, Peter Maydell wrote:
> On 13 June 2015 at 14:07, Chen Gang <address@hidden> wrote:
>> It can finish running "Hello world" elf64 binary, and the related test
>> cases:
>>
>>   - with "--enable-debug", enable assertion with "-g":
>>
>>     ./tilegx-linux-user/qemu-tilegx -L /upstream/release-tile 
>> /upstream/release-tile/test/test_shared
>>     ./tilegx-linux-user/qemu-tilegx -d all -L /upstream/release-tile 
>> /upstream/release-tile/test/test_shared > /tmp/a.log
>>
>>     ./tilegx-linux-user/qemu-tilegx /upstream/release-tile/test/test_static
>>     ./tilegx-linux-user/qemu-tilegx -d all 
>> /upstream/release-tile/test/test_static  > /tmp/b.log
>>
>>   - without "--enable-debug", disable assertion with "-O2 -g":
>>
>>     ./tilegx-linux-user/qemu-tilegx -L /upstream/release-tile 
>> /upstream/release-tile/test/test_shared
>>     ./tilegx-linux-user/qemu-tilegx -d all -L /upstream/release-tile 
>> /upstream/release-tile/test/test_shared > /tmp/c.log
>>
>>     ./tilegx-linux-user/qemu-tilegx /upstream/release-tile/test/test_static
>>     ./tilegx-linux-user/qemu-tilegx -d all 
>> /upstream/release-tile/test/test_static  > /tmp/d.log
>>
>> Chen Gang (10):
>>   linux-user: tilegx: Firstly add architecture related features
>>   linux-user: Support tilegx architecture in linux-user
>>   linux-user/syscall.c: conditionalize syscalls which are not defined in
>>     tilegx
>>   target-tilegx: Add opcode basic implementation from Tilera Corporation
>>   target-tilegx/opcode_tilegx.h: Modify it to fit QEMU usage
>>   target-tilegx: Add special register information from Tilera
>>     Corporation
>>   target-tilegx: Add cpu basic features for linux-user
>>   target-tilegx: Add several helpers for instructions translation
>>   target-tilegx: Generate tcg instructions to finish "Hello world"
>>   target-tilegx: Add TILE-Gx building files
> 
> I gave some of these my reviewed-by: tag in v11. Please don't
> just drop that, it wastes my time when I end up re-looking
> at patches I've already reviewed.
> 

OK, thanks. I shall notice next time (Add reviewer's Reviewed-by in the
already reviewed patches in the re-send patches).

> Anyway, you can add my Reviewed-by: tag to patches 1-7 and 10.
> I'll let rth do patches 8 and 9.
> 

OK, thanks.

And excuse me, I am not quite familiar with the related working flow:

 - Shall I apply these patches (with the Reviewed-by tags)? or anyone
   else help to do it?

 - If I shall be the maintainer of tilegx, what shall I do next (e.g.
   add an item to MAINTAINER, the working flow as an maintainer, next)

For me, next (after current patches are applied):

 - Give a common test (may send bug fix patches):

   Let busybox work (e.g. sh, ls, cp, mv, vi)
   Finish DejaGNU gcc testsuite for tilegx (which is my original goal).

 - Finish all instructions of tilegx (then send the new patches).

 - Try qemu system mode for tilegx (hope I can finish within this year).


> Opinions on whether we should put this series into master now
> (assuming 8 and 9 are good), or delay until after 2.4 release?
> 

OK, thanks. And welcome any other members' ideas, suggestions and
completions.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed