Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz.

[Serge Vakulenko]

On Mon, Jul 6, 2015 at 12:33 AM, Antony Pavlov <address@hidden> wrote:
> On Sun, 5 Jul 2015 21:18:11 -0700
> Serge Vakulenko <address@hidden> wrote:
>
>> On Wed, Jul 1, 2015 at 6:41 AM, Aurelien Jarno <address@hidden> wrote:
>> > On 2015-06-30 21:12, Serge Vakulenko wrote:
>> >> Signed-off-by: Serge Vakulenko <address@hidden>
>> >> ---
>> >>  hw/mips/Makefile.objs       |    3 +
>> >>  hw/mips/mips_pic32mx7.c     | 1652 +++++++++++++++++++++++++
>> >>  hw/mips/mips_pic32mz.c      | 2840 
>> >> +++++++++++++++++++++++++++++++++++++++++++
>> >>  hw/mips/pic32_ethernet.c    |  557 +++++++++
>> >>  hw/mips/pic32_gpio.c        |   39 +
>> >>  hw/mips/pic32_load_hex.c    |  238 ++++
>> >>  hw/mips/pic32_peripherals.h |  210 ++++
>> >>  hw/mips/pic32_sdcard.c      |  428 +++++++
>> >>  hw/mips/pic32_spi.c         |  121 ++
>> >>  hw/mips/pic32_uart.c        |  228 ++++
>> >>  hw/mips/pic32mx.h           | 1290 ++++++++++++++++++++
>> >>  hw/mips/pic32mz.h           | 2093 +++++++++++++++++++++++++++++++
>> >>  12 files changed, 9699 insertions(+)
>> >>  create mode 100644 hw/mips/mips_pic32mx7.c
>> >>  create mode 100644 hw/mips/mips_pic32mz.c
>> >>  create mode 100644 hw/mips/pic32_ethernet.c
>> >>  create mode 100644 hw/mips/pic32_gpio.c
>> >>  create mode 100644 hw/mips/pic32_load_hex.c
>> >>  create mode 100644 hw/mips/pic32_peripherals.h
>> >>  create mode 100644 hw/mips/pic32_sdcard.c
>> >>  create mode 100644 hw/mips/pic32_spi.c
>> >>  create mode 100644 hw/mips/pic32_uart.c
>> >>  create mode 100644 hw/mips/pic32mx.h
>> >>  create mode 100644 hw/mips/pic32mz.h
>> >
>> > This patch is huge, and needs to be splitted to ease the review.
>>
>> I'll prepare a new patch set, with every new file put into a separate
>> message. Other issues fixed as well.
>
> Putting every new file into a separate message is a nonsense.
> Please separate __logical changes__ into a single patch.

Aurelien Jarno asked to split this patch to ease the review.

> --
> Best regards,
>   Antony Pavlov