Re: [Qemu-devel] [RFC 5/7] fw_cfg file sort

[Marc Marí]

On Tue, 21 Jul 2015 21:53:06 +0200
Laszlo Ersek <address@hidden> wrote:

> On 07/21/15 18:18, Stefan Hajnoczi wrote:
> > On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí <address@hidden>
> > wrote:
> >> From: Gerd Hoffmann <address@hidden>
> >>
> >> This is what it takes to have a sorted fw_cfg file directory.
> >> Entries are inserted at the correct place instead of being
> >> appended to the end in case sorting is enabled.
> >>
> >> Compatibility fluff (enable sorting for new machine types only)
> >> isn't there yet.
> >>
> >> Signed-off-by: Gerd Hoffmann <address@hidden>
> >> ---
> >>  hw/nvram/fw_cfg.c | 30 ++++++++++++++++++++++++------
> >>  1 file changed, 24 insertions(+), 6 deletions(-)
> > 
> > Probably best to drop this patch from this series, unless it's
> > needed.
> > 
> > I guess sorting files allows for binary search but it's unrelated to
> > DMA and needs to be accompanied with guest code (e.g. SeaBIOS) that
> > actually uses the feature.
> 
> I recall another discussion where the sorting was considered under a
> migration aspect (not for the sake of binary search on the guest
> side).
> 
> .... Yes, here it is:
> 
> http://thread.gmane.org/gmane.comp.emulators.qemu/340424/focus=342398
> 
> The commit message should give a full rationale, preferably.
> 

I've not worked on it, it was already on the patches. So I'll drop it
for now, and it can be retaken in the future.

Thanks
Marc