[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] make: load only required dependency file
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] make: load only required dependency files. |
|
Date: |
Wed, 5 Aug 2015 21:51:57 +0300 |
On Wed, Aug 05, 2015 at 09:32:18PM +0300, Michael S. Tsirkin wrote:
> On Wed, Aug 05, 2015 at 08:29:33PM +0300, Victor Kaplansky wrote:
...
> > diff --git a/rules.mak b/rules.mak
> > index 6e35c36..4551b9e 100644
> > --- a/rules.mak
> > +++ b/rules.mak
> > @@ -368,6 +368,6 @@ define unnest-vars
> > $(error $o added in $v but $o-objs is not set)))
> > $(shell mkdir -p ./ $(sort $(dir $($v))))
> > # Include all the .d files
> > - $(eval -include $(addsuffix *.d, $(sort $(dir $($v)))))
> > + $(eval -include $(patsubst %.o,%.d,$(patsubst %.mo,%.d,$($v))))
>
> Pls add space after comma, like it was in the original.
For patsubst comma is pattern delimiter, so if inserted it would be part
of the pattern. Should I add a comment on this?
--Victor