Re: [Qemu-devel] [PATCH for-2.5 09/30] m68k: add X flag helpers

[Richard Henderson]

On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> +#define SET_X_FLAG(opsize, a, b) do { \
> +    switch (opsize) { \
> +    case OS_BYTE: \
> +        gen_helper_xflag_lt_i8(QREG_CC_X, a, b); break; \
> +    case OS_WORD: \
> +        gen_helper_xflag_lt_i16(QREG_CC_X, a, b); break; \
> +    case OS_LONG: \
> +        gen_helper_xflag_lt_i32(QREG_CC_X, a, b); break; \
> +    default: \
> +        abort(); \
> +    } \
> +} while (0)

No need for these helpers.  Just use setcond now, with sign-extensions as 
required for the opsize.  And perhaps not make this a macro, but a function.

Also watch all of the tcg_const_i32 without freeing the temp after.


r~