Re: [Qemu-devel] [PATCH for-2.5 11/30] m68k: improve clr/moveq

[Richard Henderson]

On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> Generate the TCG constant and use it twice, instead
> of generating the TCG constant twice to use it twice.
>
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
>   target-m68k/translate.c | 15 +++++++++------
>   1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index 359c761..8a3d315 100644
> --- a/target-m68k/translate.c
> +++ b/target-m68k/translate.c
> @@ -1431,10 +1431,13 @@ DISAS_INSN(lea)
>   DISAS_INSN(clr)
>   {
>       int opsize;
> +    TCGv zero;
> +
> +    zero = tcg_const_i32(0);

Ideally, on one line.  And it still needs to be freed.

>   DISAS_INSN(moveq)
>   {
> -    uint32_t val;
> +    TCGv val;
>
> +    val = tcg_const_i32((int8_t)insn);

Likewise.


r~