Re: [Qemu-devel] Subject: [PATCH 01/16] linux-user: tilegx: Firstly add architecture related features

[gchen gchen]

On 8/21/15 14:38, Eric Blake wrote:
> On 08/20/2015 11:30 PM, Eric Blake wrote:
>> On 08/20/2015 10:09 AM, gchen gchen wrote:
> ^^^^^^^^^^^
>
>>
>> In the subject line,
>> s/Firstly add/Add/
>>
>> ('Firstly' is seldom used in English, and certainly not in the context
>> you were trying to use it)
>>

OK, thanks.

>>> They are based on Linux kernel tilegx architecture for 64 bit binary,
>>> and also based on tilegx ABI reference document, and also reference from
>>> other targets implementations.
>>
>> s/targets/targets'/
>>

OK, thanks.


And RTH has resend these patches in v13, so it is better to let him
decide what to do with it, next (I guess, simply modifying the comments
is OK, need not send patch v14).



>>>
>>> Signed-off-by: Chen Gang <address@hidden>
> ^^^^^^^^^
>
> Also, you may want to tweak your git settings so that your Author
> designation matches your Signed-off-by designation. It is okay to use
> UTF-8 to represent your name natively, or even combine both native and
> western representations, if you are comfortable with that.

OK, thanks. "Chen Gang" is a Chinese Pinyin of my name, and it is a very
common name, too.

So I guess, still use "Chen Gang" is OK, it can be recognized by each
non-Chinese and Chinese members, easily.

My name in Chinese (precise for signature): 陈刚

> It's a bit
> more awkward to just use your login name (although it would not be the
> first time that someone has committed to qemu using an alias rather than
> a full name).
>

OK, thanks. I guess I should send mail through git client directly,
instead of my thunder bird (I shall try to config it).


Thanks.
--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed