Re: [Qemu-devel] [PULL 00/26] qemu-ga patch queue for 2015-09-01

[Michael Roth]

Quoting Peter Maydell (2015-09-01 12:12:39)
> On 1 September 2015 at 18:00, Michael Roth <address@hidden> wrote:
> > The following changes since commit 090d0bfd948343d522cd20bc634105b5cfe2483b:
> >
> >   s390: fix softmmu compilation (2015-08-28 16:05:24 +0100)
> >
> > are available in the git repository at:
> >
> >   git://github.com/mdroth/qemu.git tags/qga-pull-2015-09-01-tag
> >
> > for you to fetch changes up to 9680171bcd317927c0cbaaa291dd9072e79fb32c:
> >
> >   Makefile: qemu-ga: fix msi target error message (2015-09-01 11:40:35 
> > -0500)
> >
> > ----------------------------------------------------------------
> > qemu-ga patch queue
> >
> > * add config file dump/load support for qemu-ga
> > * various w32 build fixes, particularly WRT to msi package creation
> > * fixes for msi installer
> > * w32 support for guest-set-user-password
> 
> Hi. I'm afraid this fails to compile with our minimum glib version:
> 
> /Users/pm215/src/qemu/qga/main.c:1385:5: warning: implicit declaration of
>  function 'g_list_free_full' is invalid in C99 
> [-Wimplicit-function-declaration]
>   g_list_free_full(s->blacklist, g_free);
> 
> That function wasn't added to glib until 2.28, and our minimum is
> 2.22.

Sorry for missing this, will send a v2 shortly.

Do you happen to know a way to check/enforce max version levels for glib
functions? Apparently there's a GLIB_VERSION_MAX_ALLOWED that serves
this purpose, but it didn't generate any warnings in this particular
case:

https://developer.gnome.org/glib/stable/glib-Version-Information.html#GLIB-VERSION-MAX-ALLOWED:CAPS

If we could get that working in tree it might help with these glib compat
issues (which seem to happen fairly frequently)

> 
> thanks
> -- PMM
>