Re: [Qemu-devel] [PULL 00/26] qemu-ga patch queue for 2015-09-01

[John Snow]

On 09/01/2015 02:37 PM, Peter Maydell wrote:
> On 1 September 2015 at 19:33, Michael Roth <address@hidden> wrote:
>> Quoting Peter Maydell (2015-09-01 12:12:39)
>>> That function wasn't added to glib until 2.28, and our minimum is
>>> 2.22.
>>
>> Sorry for missing this, will send a v2 shortly.
>>
>> Do you happen to know a way to check/enforce max version levels for glib
>> functions?
> 
> The only way I know that works is "do a test compile against 2.22".
> 
>> Apparently there's a GLIB_VERSION_MAX_ALLOWED that serves
>> this purpose, but it didn't generate any warnings in this particular
>> case:
>>
>> https://developer.gnome.org/glib/stable/glib-Version-Information.html#GLIB-VERSION-MAX-ALLOWED:CAPS
>>
>> If we could get that working in tree it might help with these glib compat
>> issues (which seem to happen fairly frequently)
> 
> David Gilbert had a look at that a little while back, but it's
> trickier than it first looks.
> 
> thanks
> -- PMM
> 

I've looked at it before, too. The problem is that we have backported
some glib functionality from beyond 2.22 and these macros will fuss at
our usage of those functions too, IIRC.

We could solve this by *always* using our own version of a glib-provided
function if it's from beyond 2.22 and then torpedoing the glib-compat file.

--js