Re: [Qemu-devel] [PATCH v2 00/49] audio: -audiodev option, multiple options

[Gerd Hoffmann]

On Fr, 2015-08-21 at 17:36 +0200, Kővágó, Zoltán wrote:
> This patch series adds support to multiple audio backends.  Afterwards I
> add support to multiple backends.  Audio fronteds gain a new audiodev
> option to specify the id of the audiodev to use.  The audiodev= option
> is required, unless you use the old environment variable based
> configuration, in that case it must not used (and you can't use multiple
> backends). 
> 
> Finally I also make mixeng usage optional, it can save us some useless
> format converting when not needed.  Also makes easier to support formats
> currently not supported by qemu (as only the backend has to support it,
> not the mixeng).
> 
> For easier testing pull https://github.com/DirtYiCE/qemu.git tag 
> audio-multi-v2.
> 
> Please review.

Looks good overall to me, passed some simple testing.  Want do more
testing before merging, need to find some time for it.  Also we need to
get the qapi bits merged first.

There are some issues flagged by codestyle.pl.  For a good part they are
already in the existing code.  Sometimes you fixed the existing
problems, sometimes you didn't.  A few new issues (long lines for
example) are there too.  But given how many issues in existing audio
code we have I guess the easiest way to handle this is to fix it
afterwards with indent.

cheers,
  Gerd