Re: [Qemu-devel] [PATCH v2 00/49] audio: -audiodev option, multiple options

[Kővágó Zoltán]

2015-09-03 12:15 keltezéssel, Gerd Hoffmann írta:
> On Fr, 2015-08-21 at 17:36 +0200, Kővágó, Zoltán wrote:
> > This patch series adds support to multiple audio backends.  Afterwards I
> > add support to multiple backends.  Audio fronteds gain a new audiodev
> > option to specify the id of the audiodev to use.  The audiodev= option
> > is required, unless you use the old environment variable based
> > configuration, in that case it must not used (and you can't use multiple
> > backends).
> >
> > Finally I also make mixeng usage optional, it can save us some useless
> > format converting when not needed.  Also makes easier to support formats
> > currently not supported by qemu (as only the backend has to support it,
> > not the mixeng).
> >
> > For easier testing pull https://github.com/DirtYiCE/qemu.git tag
> > audio-multi-v2.
> >
> > Please review.
>
> Adding qapi & net folks to Cc.  Ping.
>
> How to go forward with the QAPI bits in this series (Patches 1-9)?
> Patch #1 got reviews from block folks.  Patch #3 has a comment from
> Eduardo pending.  What about the other ones?  Fine as-is?  I remember
> from the pre-2.4 freeze discussions that there at least was agreement
> that flattening the qapi structs is the way to go.

Eduardo's comment was about s/NumaDriver/NumaOptionType/, and I didn't 
want to resend the whole series just to fix this small problem (as there 
will be other problems too, I think).  IIRC Markus still had opposition 
with patch #9 (support nested structs in OptsVisitor).

Zoltan