[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RESEND PATCHv2] sdhci: Pass drive parameter to sdhci-p
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RESEND PATCHv2] sdhci: Pass drive parameter to sdhci-pci via qdev property |
Date: |
Thu, 3 Sep 2015 15:56:26 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Aug 17, 2015 at 03:20:33PM -0400, Kevin O'Connor wrote:
> Commit 19109131 disabled the sdhci-pci support because it used
> drive_get_next(). This patch reenables sdhci-pci and changes it to
> pass the drive via a qdev property - for example:
> -device sdhci-pci,drive=drive0 -drive id=drive0,if=sd,file=myimage
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Kevin O'Connor <address@hidden>
> ---
>
> This is a resend of the patch I sent two weeks ago. No changes (other
> than adding Stefan's reviewed-by line).
>
> v2:
> - Don't call blk_detach_dev() in sdhci pci code - instead change
> sd_init() to use blk_attach_dev() instead of blk_attach_dev_nofail().
>
> ---
> hw/sd/sd.c | 4 +++-
> hw/sd/sdhci.c | 32 +++++++++++++++++++-------------
> hw/sd/sdhci.h | 2 ++
> 3 files changed, 24 insertions(+), 14 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [RESEND PATCHv2] sdhci: Pass drive parameter to sdhci-pci via qdev property,
Stefan Hajnoczi <=