Re: [Qemu-devel] [PATCH v2 05/18] acpi: add aml_create_field

[Xiao Guangrong]

On 09/02/2015 07:10 PM, Igor Mammedov wrote:
> On Fri, 14 Aug 2015 22:51:58 +0800
> Xiao Guangrong <address@hidden> wrote:
>
> > Implement CreateField term which are used by NVDIMM _DSM method in later patch
> >
> > Signed-off-by: Xiao Guangrong <address@hidden>
> > ---
> >   hw/acpi/aml-build.c         | 14 ++++++++++++++
> >   include/hw/acpi/aml-build.h |  1 +
> >   2 files changed, 15 insertions(+)
> >
> > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> > index a526eed..debdad2 100644
> > --- a/hw/acpi/aml-build.c
> > +++ b/hw/acpi/aml-build.c
> > @@ -1151,6 +1151,20 @@ Aml *aml_sizeof(Aml *arg)
> >       return var;
> >   }
> >
> > +/* ACPI 6.0: 20.2.5.2 Named Objects Encoding: DefCreateField */
> ditto, refer to to the first revision where it's appeared

Well do it.

> > +Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name)
> index and len could be only of 'Integer' type, so there is no point
> to pass them in as Aml, just use uintFOO_t here and convert
> them to aml_int() internally. That way call sites will be smaller
> and have less chance to pass a wrong Aml variable.

Good idea.

BTW, Igor, sorry for the delay reply since we got a holiday in this week.