Re: [Qemu-devel] [PATCH] vhost-scsi: fix wrong vhost-scsi firmware path

[Paolo Bonzini]

On 26/08/2015 03:52, address@hidden wrote:
> From: Gonglei <address@hidden>
> 
> vhost-scsi bootindex does't work because Qemu passes
> wrong fireware path to seabios.
> 
> before:
>   /address@hidden/address@hidden@0/address@hidden,0
> after applying the patch:
>   /address@hidden/address@hidden/address@hidden/address@hidden,0
> 
> Reported-by: Subo <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> ---
>  hw/scsi/vhost-scsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
> index 7eacca9..bac9ddb 100644
> --- a/hw/scsi/vhost-scsi.c
> +++ b/hw/scsi/vhost-scsi.c
> @@ -292,7 +292,7 @@ static char *vhost_scsi_get_fw_dev_path(FWPathProvider 
> *p, BusState *bus,
>  {
>      VHostSCSI *s = VHOST_SCSI(dev);
>      /* format: address@hidden/address@hidden,lun */
> -    return g_strdup_printf("address@hidden/address@hidden,%x", s->channel,
> +    return g_strdup_printf("/address@hidden/address@hidden,%x", s->channel,
>                             qdev_fw_name(dev), s->target, s->lun);
>  }
>  
> 

I was on vacation. :)  Thanks, I applied this now.

Paolo