[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 09/26] qapi: De-duplicate enum code generatio
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v7 09/26] qapi: De-duplicate enum code generation |
Date: |
Tue, 15 Sep 2015 11:46:27 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Sep 14, 2015 at 07:57:40PM +0200, Markus Armbruster wrote:
> Duplicated in commit 21cd70d. Yes, we can't import qapi-types, but
> that's no excuse. Move the helpers from qapi-types.py to qapi.py, and
> replace the duplicates in qapi-event.py.
>
> The generated event enumeration type's lookup table becomes
> const-correct (see commit 2e4450f), and uses explicit indexes instead
> of relying on order (see commit 912ae9c).
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> docs/qapi-code-gen.txt | 9 ++++---
> scripts/qapi-event.py | 67
> +++-----------------------------------------------
> scripts/qapi-types.py | 55 -----------------------------------------
> scripts/qapi.py | 55 +++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 64 insertions(+), 122 deletions(-)
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH v7 00/26] qapi: QMP introspection, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 04/26] qapi: New QAPISchemaVisitor, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 03/26] qapi: QAPISchema code generation helper methods, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 01/26] qapi: Rename class QAPISchema to QAPISchemaParser, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 14/26] qapi-visit: Rearrange code a bit, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 02/26] qapi: New QAPISchema intermediate reperesentation, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 09/26] qapi: De-duplicate enum code generation, Markus Armbruster, 2015/09/14
- Re: [Qemu-devel] [PATCH v7 09/26] qapi: De-duplicate enum code generation,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH v7 08/26] qapi-commands: Convert to QAPISchemaVisitor, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 12/26] qapi: Replace dirty is_c_ptr() by method c_null(), Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 11/26] qapi-event: Convert to QAPISchemaVisitor, fixing data with base, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 19/26] qapi: Improve built-in type documentation, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 20/26] qapi: Make output visitor return qnull() instead of NULL, Markus Armbruster, 2015/09/14