[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 13/26] qapi: Clean up after recent conversion
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v7 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor |
Date: |
Tue, 15 Sep 2015 11:52:26 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Sep 14, 2015 at 07:57:44PM +0200, Markus Armbruster wrote:
> Generate just 'FOO' instead of 'struct FOO' when possible.
>
> Drop helper functions that are now unused.
>
> Make pep8 and pylint reasonably happy.
>
> Rename generate_FOO() functions to gen_FOO() for consistency.
>
> Use more consistent and sensible variable names.
>
> Consistently use c_ for mapping keys when their value is a C
> identifier or type.
>
> Simplify gen_enum() and gen_visit_union()
>
> Consistently use single quotes for C text string literals.
I would have preferred to see one type of change per
patch to make review easier, but this has been through
enough iterations now that no point changing again.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> docs/qapi-code-gen.txt | 2 +-
> scripts/qapi-commands.py | 140
> ++++++++++++++++++++++++++---------------------
> scripts/qapi-event.py | 122 ++++++++++++++++++++---------------------
> scripts/qapi-types.py | 79 ++++++++++++++------------
> scripts/qapi-visit.py | 127 ++++++++++++++++++++++--------------------
> scripts/qapi.py | 131 +++++++++-----------------------------------
> 6 files changed, 274 insertions(+), 327 deletions(-)
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH v7 17/26] qapi: De-duplicate parameter list generation, (continued)
- [Qemu-devel] [PATCH v7 17/26] qapi: De-duplicate parameter list generation, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 05/26] tests/qapi-schema: Convert test harness to QAPISchemaVisitor, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 10/26] qapi-event: Eliminate global variable event_enum_value, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 22/26] qom: Don't use 'gen': false for qom-get, qom-set, object-add, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 07/26] qapi-visit: Convert to QAPISchemaVisitor, fixing bugs, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 06/26] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor, Markus Armbruster, 2015/09/14
- Re: [Qemu-devel] [PATCH v7 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH v7 24/26] qapi: Pseudo-type '**' is now unused, drop it, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 15/26] qapi-commands: Rearrange code, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 26/26] qapi-introspect: Hide type names, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 21/26] qapi: Introduce a first class 'any' type, Markus Armbruster, 2015/09/14
- [Qemu-devel] [PATCH v7 18/26] qapi-commands: De-duplicate output marshaling functions, Markus Armbruster, 2015/09/14