[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 44/46] ivshmem: remove EventfdEntry.vector
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v3 44/46] ivshmem: remove EventfdEntry.vector |
Date: |
Tue, 22 Sep 2015 17:18:34 +0200 |
Hi
On Tue, Sep 22, 2015 at 4:59 PM, Claudio Fontana
<address@hidden> wrote:
> This one does not seem particularly valuable to me.. btw isn't it slightly
> easier to debug with the vector in the structure?
Yeah, it's just is a bit superflous to me store the vector index in
all the elements.
You get the vector index calculated and printed in debug, so I failed
to see what it removes for debugging.
--
Marc-André Lureau
- Re: [Qemu-devel] [PATCH v3 41/46] ivshmem: do not keep shm_fd open, (continued)
- [Qemu-devel] [PATCH v3 42/46] ivshmem: make ivshmem_get_size() more generic, marcandre . lureau, 2015/09/15
- [Qemu-devel] [PATCH v3 43/46] ivshmem: add hostmem backend, marcandre . lureau, 2015/09/15
- [Qemu-devel] [PATCH v3 44/46] ivshmem: remove EventfdEntry.vector, marcandre . lureau, 2015/09/15
- [Qemu-devel] [PATCH v3 45/46] ivshmem: rename MSI eventfd_table, marcandre . lureau, 2015/09/15
- [Qemu-devel] [PATCH v3 46/46] ivshmem: use kvm irqfd for msi notifications, marcandre . lureau, 2015/09/15
- Re: [Qemu-devel] [PATCH v3 00/46] ivshmem improvements (please review), Claudio Fontana, 2015/09/16
- Re: [Qemu-devel] [PATCH v3 00/46] ivshmem improvements (please review), Vladimir Sementsov-Ogievskiy, 2015/09/16