[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 21/21] qemu-char: cleanup after completed conver
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 21/21] qemu-char: cleanup after completed conversion to cd->create |
Date: |
Mon, 12 Oct 2015 09:55:02 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/12/2015 02:03 AM, Paolo Bonzini wrote:
> All backends now return errors through Error*, so the "Failed to
> create chardev" placeholder error can only be reached if the backend
> is not available (and only from the chardev-add QMP command; instead,
> the -chardev command line option fails earlier).
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> qemu-char.c | 80
> ++++---------------------------------------------------------
> 1 file changed, 4 insertions(+), 76 deletions(-)
>
Nice diffstat ratio!
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 09/21] qemu-char: convert UDP backend to data-driven creation, (continued)
- [Qemu-devel] [PATCH 13/21] qemu-char: convert msmouse backend to data-driven creation, Paolo Bonzini, 2015/10/12
- [Qemu-devel] [PATCH 15/21] qemu-char: convert testdev backend to data-driven creation, Paolo Bonzini, 2015/10/12
- [Qemu-devel] [PATCH 16/21] qemu-char: convert stdio backend to data-driven creation, Paolo Bonzini, 2015/10/12
- [Qemu-devel] [PATCH 17/21] qemu-char: convert console backend to data-driven creation, Paolo Bonzini, 2015/10/12
- [Qemu-devel] [PATCH 21/21] qemu-char: cleanup after completed conversion to cd->create, Paolo Bonzini, 2015/10/12
- Re: [Qemu-devel] [PATCH 21/21] qemu-char: cleanup after completed conversion to cd->create,
Eric Blake <=
- [Qemu-devel] [PATCH 20/21] qemu-char: convert ringbuf backend to data-driven creation, Paolo Bonzini, 2015/10/12
- [Qemu-devel] [PATCH 18/21] qemu-char: convert spice backend to data-driven creation, Paolo Bonzini, 2015/10/12
- [Qemu-devel] [PATCH 01/21] qemu-char: cleanup qmp_chardev_add, Paolo Bonzini, 2015/10/15
- [Qemu-devel] [PATCH 07/21] qemu-char: convert pipe backend to data-driven creation, Paolo Bonzini, 2015/10/15