Re: [Qemu-devel] [PULL v3 00/13] qemu-ga patch queue

[Peter Maydell]

On 17 October 2015 at 17:59, Michael Roth <address@hidden> wrote:
> Hi Peter,
>
> Please note that 'glib-compat: add 2.38/2.40/2.46 asserts' is also in
> Marc-André's recent ivshmem PULL. The 2 versions of the patches are identical,
> but let me know if you'd prefer a re-send/re-base later.
>
> The following changes since commit 6d57410a79d51d92673c54f26624b44f27fa6214:
>
>   Merge remote-tracking branch 
> 'remotes/pmaydell/tags/pull-target-arm-20151016' into staging (2015-10-17 
> 12:31:33 +0100)
>
> are available in the git repository at:
>
>
>   git://github.com/mdroth/qemu.git tags/qga-pull-2015-10-14-v3-tag
>
> for you to fetch changes up to ed9f1986d19c2d21667a14b875b2ac8b8a19b8a5:
>
>   qga: fix uninitialized value warning for win32 (2015-10-17 11:24:27 -0500)
>
> ----------------------------------------------------------------
> qemu-ga patch queue
>
> * add unit tests for qemu-ga
> * add guest-exec support for posix/w32 guests
> * added 'qemu-ga' target for w32. this allows us to do full MSI build,
>   without overloading 'qemu-ga.exe' target with uneeded dependencies.
> * number of s/g_new/g_malloc/ conversions for qga
>
> v2:
> * commit message and qapi documentation spelling fixes
> * rename 'inp-data' guest-exec param to 'input-data'
>
> v3:
> * fix OSX build errors for test-qga by using PRId64
>   format in place of glib's, and dropping use of G_SPAWN_DEFAULT
>   macro for glib 2.22 compat
> * fix win32 build warnings for 32-bit builds by avoid int casts
>   of process HANDLEs

Still seeing failures, I'm afraid.

OSX assertion failures:

GTESTER tests/test-qga
**
ERROR:/Users/pm215/src/qemu-for-merges/tests/libqtest.c:238:void
socket_send(int, const char *, size_t): assertion failed (len != -1):
(-1 != -1)
GTester: last random seed: R02S96655a200709f74b72ea42792cd65e8e

(repeated about 10 times).

Test failures on 64-bit ARM:
TEST: tests/test-qga... (pid=22454)
  /qga/sync-delimited:                                                 OK
  /qga/sync:                                                           OK
  /qga/ping:                                                           OK
  /qga/info:                                                           OK
  /qga/network-get-interfaces:                                         OK
  /qga/get-vcpus:                                                      OK
  /qga/get-fsinfo:                                                     OK
  /qga/get-memory-block-info:                                          **
ERROR:/home/petmay01/qemu/tests/test-qga.c:294:test_qga_get_memory_block_info:
assertion failed ret: GenericError
open("/sys/devices/system/memory/"): No such file or directory
FAIL
GTester: last random seed: R02S6aa3e1f8b691a9900d2ea9945e79869d
(pid=22458)
  /qga/get-memory-blocks:                                              **
ERROR:/home/petmay01/qemu/tests/test-qga.c:313:test_qga_get_memory_blocks:
assertion failed ret: GenericError Can't open
directory"/sys/devices/system/memory/"
: No such file or directory
FAIL
GTester: last random seed: R02S978afb04187410dc690a8b7d6d236793
(pid=22461)
  /qga/file-ops:                                                       OK
  /qga/get-time:                                                       OK
  /qga/invalid-cmd:                                                    OK
  /qga/fsfreeze-status:                                                OK
  /qga/blacklist:                                                      OK
  /qga/config:                                                         OK
FAIL: tests/test-qga
make: *** [check-tests/test-qga] Error 1

Not sure why it's complaining, /sys/devices/system/memory/ does
exist on this box.

Ditto on 32-bit ARM, though that's not surprising as it's just
a chroot on an equivalently-configured machine to the 64-bit build.

thanks
-- PMM