[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used b
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI |
Date: |
Mon, 19 Oct 2015 11:46:35 +0200 |
On Mon, 19 Oct 2015 12:17:22 +0300
"Michael S. Tsirkin" <address@hidden> wrote:
> On Mon, Oct 19, 2015 at 03:44:13PM +0800, Xiao Guangrong wrote:
> >
> >
> > On 10/19/2015 03:39 PM, Michael S. Tsirkin wrote:
> > >On Mon, Oct 19, 2015 at 03:27:21PM +0800, Xiao Guangrong wrote:
> > >>>>+ nvdimm_init_memory_state(&pcms->nvdimm_memory,
> > >>>>system_memory, machine,
> > >>>>+ TARGET_PAGE_SIZE);
> > >>>>+
> > >>>
> > >>>Shouldn't this be conditional on presence of the nvdimm device?
> > >>>
> > >>
> > >>We will enable hotplug on nvdimm devices in the near future once
> > >>Linux driver is ready. I'd keep it here for future development.
> > >
> > >No, I don't think we should add stuff unconditionally. If not
> > >nvdimm, some other flag should indicate user intends to hotplug
> > >things.
> > >
> >
> > Actually, it is not unconditionally which is called if parameter
> > "-m aaa, maxmem=bbb" (aaa < bbb) is used. It is on the some path of
> > memoy-hotplug initiation.
> >
>
> Right, but that's not the same as nvdimm.
>
it could be pc-machine property, then it could be turned on like this:
-machine nvdimm_support=on
- Re: [Qemu-devel] [PATCH v3 04/32] acpi: add aml_mutex, aml_acquire, aml_release, (continued)
- [Qemu-devel] [PATCH v3 10/32] hostmem-file: clean up memory allocation, Xiao Guangrong, 2015/10/10
- [Qemu-devel] [PATCH v3 12/32] pc-dimm: remove DEFAULT_PC_DIMMSIZE, Xiao Guangrong, 2015/10/10
- [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI, Xiao Guangrong, 2015/10/10
- Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI, Michael S. Tsirkin, 2015/10/19
- Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI, Xiao Guangrong, 2015/10/19
- Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI, Michael S. Tsirkin, 2015/10/19
- Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI, Xiao Guangrong, 2015/10/19
- Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI, Michael S. Tsirkin, 2015/10/19
- Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI,
Igor Mammedov <=
- Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI, Xiao Guangrong, 2015/10/19
- Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI, Michael S. Tsirkin, 2015/10/19
- Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI, Igor Mammedov, 2015/10/19
- Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI, Xiao Guangrong, 2015/10/19
- Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI, Xiao Guangrong, 2015/10/19
- Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI, Igor Mammedov, 2015/10/19
- Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI, Michael S. Tsirkin, 2015/10/19
- Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI, Xiao Guangrong, 2015/10/19
- Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI, Michael S. Tsirkin, 2015/10/19
[Qemu-devel] [PATCH v3 16/32] pc-dimm: rename pc-dimm.c and pc-dimm.h, Xiao Guangrong, 2015/10/10