[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support f
From: |
Pavel Fedin |
Subject: |
Re: [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support files |
Date: |
Wed, 21 Oct 2015 16:39:15 +0300 |
Hello!
> Do you mean that in virt.c::create_gic I'll take the cpu's affinity from the
> cpu's property and not directly from
> ARM_CPU(qemu_get_cpu(i))->mp_affinity
I mean that you can do it in your GIC's realize function. And, even better, in
arm_gicv3_common_realize(), because KVM GICv3 live migration code will also
need it:
--- cut ---
for (i = 0; i < s->num_cpu; i++) {
Object *cpu = OBJECT(qemu_get_cpu(i));
s->cpu[i].mp_affinity = object_property_get_int(cpu, "mp-affinity", NULL);
}
--- cut ---
> I can do that but that depends on acceptance of your patch.
Peter ACKed it, just he doesn't like having unused code:
http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg03105.html
Just include it into your next respin and forget. :) Actually, i made my RFC
so that you could just take 0001 and 0002 from it and use for your purpose.
With additions, of course, if necessary.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia