[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qapi-schema: mark InetSocketAddress as mandator
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] qapi-schema: mark InetSocketAddress as mandatory again |
|
Date: |
Thu, 22 Oct 2015 07:57:04 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/22/2015 06:42 AM, Daniel P. Berrange wrote:
>>> +++ b/qapi-schema.json
>>> @@ -2614,9 +2614,7 @@
>>> #
>>> # @host: host part of the address
>>> #
>>> -# @port: port part of the address, or lowest port if @to is present.
>>> -# Kernel selects a free port if omitted for listener addresses.
>>> -# #optional
>>> +# @port: port part of the address, or lowest port if @to is present
>>
>> Don't you still want to allow an empty string as the way to allow kernel
>> port selection?
>
> I only needed the support for empty port for the sake of the unit
> tests, which doesn't use QAPI parsing code. Enabling it via the command
> line / monitor was just a happy accident, so I figure this is fine for
> 2.5. We can re-revert it in 2.6 when you change the QAPI generator
Fair enough; then you can add:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature