[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 35/54] Postcopy: Postcopy startup in migratio
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v8 35/54] Postcopy: Postcopy startup in migration thread |
Date: |
Mon, 26 Oct 2015 17:12:15 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
* Juan Quintela (address@hidden) wrote:
> "Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> >
> > Rework the migration thread to setup and start postcopy.
> >
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> > Reviewed-by: Amit Shah <address@hidden>
>
>
> > diff --git a/include/migration/migration.h b/include/migration/migration.h
> > index aecf284..0586f8c 100644
> > --- a/include/migration/migration.h
> > +++ b/include/migration/migration.h
> > @@ -136,6 +136,9 @@ struct MigrationState
> > /* Flag set once the migration has been asked to enter postcopy */
> > bool start_postcopy;
> >
> > + /* Flag set once the migration thread is running (and needs joining) */
> > + bool migration_thread_started;
> > +
> > /* bitmap of pages that have been sent at least once
> > * only maintained and used in postcopy at the moment
> > * where it's used to send the dirtymap at the start
>
> if you split it, we can already integrate the migration_thread_started.
>
> I would suggest to change the name to migration_thread_running, but you
> are the native one here O:-)
Changed.
> If you don't want to add this variable, I *think* we could use
> MIGRATION_STATE_NONE with just some little rearangements of the code.
> On the other hand, it could be racy :-(
Yeh, it seemed simpler to have a nice simple bool.
> Reviewed-by: Juan Quintela <address@hidden>
>
>
> Split only or rename variable just if you consider it convenient.
Renamed, not split.
Dave
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v8 31/54] Add qemu_savevm_state_complete_postcopy, (continued)
- [Qemu-devel] [PATCH v8 31/54] Add qemu_savevm_state_complete_postcopy, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 34/54] postcopy: ram_enable_notify to switch on userfault, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 37/54] Postcopy: End of iteration, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 33/54] postcopy: Incoming initialisation, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 35/54] Postcopy: Postcopy startup in migration thread, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 36/54] Split out end of migration code from migration_thread, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 38/54] Page request: Add MIG_RP_MSG_REQ_PAGES reverse command, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 39/54] Page request: Process incoming page request, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 40/54] Page request: Consume pages off the post-copy queue, Dr. David Alan Gilbert (git), 2015/10/01