[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_siz
From: |
Xiao Guangrong |
Subject: |
Re: [Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_size() |
Date: |
Sat, 31 Oct 2015 15:26:20 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/30/2015 09:26 PM, Vladimir Sementsov-Ogievskiy wrote:
logic is changed:
in old version gethugepagesize on statfs error generates exit(1)
in new it returns getpagesize() in this case (through fd_getpagesize)
(I think, fd_getpagesize should be fixed to handle error)
Indeed. I will let fd_getpagesize() return 0 if statfs is failed, then the
caller
handle the error properly.
also, in new version for windows we have getpagesize(), when in old version
there was no difference
(how did it work?). May be it's ok, but should be mentioned in commit message
Windows did not support file hugepage, so it will return normal page for this
case. And this interface has not been used on windows so far.
I will document it in the commit message as your suggestion.
- [Qemu-devel] [PATCH v6 00/33] implement vNVDIMM, Xiao Guangrong, 2015/10/30
- [Qemu-devel] [PATCH v6 01/33] acpi: add aml_derefof, Xiao Guangrong, 2015/10/30
- [Qemu-devel] [PATCH v6 02/33] acpi: add aml_sizeof, Xiao Guangrong, 2015/10/30
- [Qemu-devel] [PATCH v6 03/33] acpi: add aml_create_field, Xiao Guangrong, 2015/10/30
- [Qemu-devel] [PATCH v6 04/33] acpi: add aml_concatenate, Xiao Guangrong, 2015/10/30
- [Qemu-devel] [PATCH v6 05/33] acpi: add aml_object_type, Xiao Guangrong, 2015/10/30
- [Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_size(), Xiao Guangrong, 2015/10/30
- Re: [Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_size(), Eduardo Habkost, 2015/10/30
- Re: [Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_size(), Xiao Guangrong, 2015/10/31
[Qemu-devel] [PATCH v6 06/33] acpi: add aml_method_serialized, Xiao Guangrong, 2015/10/30
[Qemu-devel] [PATCH v6 12/33] pc-dimm: remove DEFAULT_PC_DIMMSIZE, Xiao Guangrong, 2015/10/30
[Qemu-devel] [PATCH v6 10/33] hostmem-file: clean up memory allocation, Xiao Guangrong, 2015/10/30