Re: [Qemu-devel] [PATCH] fixup! char: Convert to new qapi union layout

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> Fix build failure on w32
>
> Signed-off-by: Eric Blake <address@hidden>

Squashed, thanks!

> ---
>
> Hopefully, this is the only use of qapi union types hiding
> behind #ifdefs (I relied on the compiler to tell me which spots
> need conversion, but that doesn't work for spots that aren't
> compiled in my setup)

We could've generated a semantic patch for Coccinelle.  Not foolproof,
either, as Coccinelle can miss things when its parser heuristics fail.
Anyway, not worth it now.