Re: [Qemu-devel] [PATCH COLO-Frame v10 34/38] filter-buffer: Accept zero interval

[Yang Hongyang]

Some commit message would be better.

On 2015年11月03日 19:56, zhanghailiang wrote:
> Signed-off-by: zhanghailiang <address@hidden>
> Cc: Jason Wang <address@hidden>

Reviewed-by: Yang Hongyang <address@hidden>

> ---
> v10: new patch
> ---
>   net/filter-buffer.c | 10 ----------
>   1 file changed, 10 deletions(-)
>
> diff --git a/net/filter-buffer.c b/net/filter-buffer.c
> index 5f0ea70..05313de 100644
> --- a/net/filter-buffer.c
> +++ b/net/filter-buffer.c
> @@ -104,16 +104,6 @@ static void filter_buffer_setup(NetFilterState *nf, Error 
> **errp)
>   {
>       FilterBufferState *s = FILTER_BUFFER(nf);
>
> -    /*
> -     * We may want to accept zero interval when VM FT solutions like MC
> -     * or COLO use this filter to release packets on demand.
> -     */
> -    if (!s->interval) {
> -        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "interval",
> -                   "a non-zero interval");
> -        return;
> -    }
> -
>       s->incoming_queue = qemu_new_net_queue(qemu_netfilter_pass_to_next, nf);
>       if (s->interval) {
>           timer_init_us(&s->release_timer, QEMU_CLOCK_VIRTUAL,

--
Thanks,
Yang