[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH 22/77] ppc: Add real mode CI load/sto
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH 22/77] ppc: Add real mode CI load/store instructions for P7 and P8 |
Date: |
Tue, 24 Nov 2015 11:58:26 +1100 |
On Fri, 2015-11-20 at 18:48 +1100, David Gibson wrote:
>
> > @@ -380,9 +380,11 @@ typedef struct opcode_t {
> > #if defined(CONFIG_USER_ONLY)
> > #define CHK_HV GEN_PRIV
> > #define CHK_SV GEN_PRIV
> > +#define CHK_HVDR GEN_PRIV
>
> I'm guessing this is supposed to be CHK_HVRM as below.
Indeed. I had test built ... odd.
> > #else
> > #define CHK_HV do { if (unlikely(ctx->pr || !ctx->hv)) GEN_PRIV; } while(0)
> > #define CHK_SV do { if (unlikely(ctx->pr)) GEN_PRIV; } while(0)
> > +#define CHK_HVRM do { if (unlikely(ctx->pr || !ctx->hv || ctx->dr))
> > GEN_PRIV; } while(0)
> > #endif
> >
> > #define CHK_NONE
> > @@ -2887,7 +2889,7 @@ static void glue(gen_, name##u)(DisasContext *ctx)
> > }
> >
> > #define GEN_LDUX(name, ldop, opc2, opc3, type)
> > \
> > -static void glue(gen_, name##ux)(DisasContext *ctx)
> > \
> > +static void glue(gen_, name##ux)(DisasContext *ctx)
> > \
>
> Extraneous change.
Fixed. Thanks.
Cheers,
Ben.
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 00/77] ppc: Add "native" POWER8 platform, (continued)
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 00/77] ppc: Add "native" POWER8 platform, Stewart Smith, 2015/11/10
- [Qemu-devel] [PATCH 24/77] ppc: Move exception generation code out of line, Benjamin Herrenschmidt, 2015/11/10
- [Qemu-devel] [PATCH 37/77] ppc/xics: Split ICS into base class and "simple" implementation, Benjamin Herrenschmidt, 2015/11/10
- [Qemu-devel] [PATCH 10/77] ppc: Fix hreg_store_msr() so that non-HV mode cannot alter MSR:HV, Benjamin Herrenschmidt, 2015/11/10
- [Qemu-devel] [PATCH 22/77] ppc: Add real mode CI load/store instructions for P7 and P8, Benjamin Herrenschmidt, 2015/11/10
- [Qemu-devel] [PATCH 15/77] ppc: Fix sign extension issue in mtmsr(d) emulation, Benjamin Herrenschmidt, 2015/11/10
- [Qemu-devel] [PATCH 16/77] ppc: Get out of emulation on SMT "OR" ops, Benjamin Herrenschmidt, 2015/11/10
- [Qemu-devel] [PATCH 48/77] ppc/pnv: Add model for Power8 PHB3 PCIe Host bridge, Benjamin Herrenschmidt, 2015/11/10