[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.6 01/14] block: Add "file" output paramete
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.6 01/14] block: Add "file" output parameter to block status query functions |
|
Date: |
Tue, 24 Nov 2015 21:01:51 +0800 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, 11/24 13:51, Paolo Bonzini wrote:
>
>
> On 24/11/2015 13:50, Fam Zheng wrote:
> > > > + if (bs->file && *file == bs->file->bs &&
> > >
> > > This check is unnecessary, just use "if (file)".
> >
> > "file" would be bs in the case of protocol, and this function will
> > infinitely
> > recurse.
>
> Oh, that's right! But then I think we want to check that and allow
> recursion to any *file, not just bs->file->bs.
>
That makes sense, I'll make it to.
Fam
[Qemu-devel] [PATCH for-2.6 03/14] qcow2: Assign bs->file->bs to file in qcow2_co_get_block_status, Fam Zheng, 2015/11/24
[Qemu-devel] [PATCH for-2.6 04/14] raw: Assign bs to file in raw_co_get_block_status, Fam Zheng, 2015/11/24
[Qemu-devel] [PATCH for-2.6 05/14] iscsi: Assign bs to file in iscsi_co_get_block_status, Fam Zheng, 2015/11/24
[Qemu-devel] [PATCH for-2.6 06/14] parallels: Assign bs->file->bs to file in parallels_co_get_block_status, Fam Zheng, 2015/11/24
[Qemu-devel] [PATCH for-2.6 07/14] qed: Assign bs->file->bs to file in bdrv_qed_co_get_block_status, Fam Zheng, 2015/11/24
[Qemu-devel] [PATCH for-2.6 08/14] sheepdog: Assign bs to file in sd_co_get_block_status, Fam Zheng, 2015/11/24
[Qemu-devel] [PATCH for-2.6 09/14] vdi: Assign bs->file->bs to file in vdi_co_get_block_status, Fam Zheng, 2015/11/24