Re: [Qemu-devel] [PATCH] arm: soc-dma: use hwaddr instead of target_ulong in printf

[Peter Maydell]

On 4 December 2015 at 16:52, Peter Maydell <address@hidden> wrote:
> On 4 December 2015 at 16:39, Paolo Bonzini <address@hidden> wrote:
>>
>>> I don't think we've ever said "we should transition away from HWADDR_*",
>>> but whether we should is an interesting question, which is why I asked.
>>> Does retaining the format macros to go with the typedef give us
>>> useful flexibility, or is it just confusing?
>>
>> I think it's confusing, but not enough to warrant a tree-wide search
>> and replace.
>
> I think I agree :-)
>
> Reviewed-by: Peter Maydell <address@hidden>
>
> and I'll queue this in target-arm.next for 2.6.

Now in target-arm.next. I also did s/__FUNCTION__/__func__/
since checkpatch complains about it and we're touching these lines
of code anyway.

thanks
-- PMM