Re: [Qemu-devel] [PATCH 05/12] Added support for serial eeproms - AT25128A/AT25256A

[Peter Crosthwaite]

Subsystem prefix needed in commit subject (block: m25p80). Bring the
mention of specific parts to the paragraph to shorten the subject.

On Wed, Dec 16, 2015 at 4:57 AM,  <address@hidden> wrote:
> From: Marcin Krzeminski <address@hidden>
>
> Signed-off-by: Marcin Krzeminski <address@hidden>
> ---
>  hw/block/m25p80.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index fbbfd1d..1a547ae 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -94,6 +94,11 @@ static const FlashPartInfo known_devices[] = {
>
>      { INFO("at45db081d",  0x1f2500,      0,  64 << 10,  16, ER_4K) },
>
> +    /* Atmel EEPROMS - it is assumed, that don't care bit in command */

Multi-line comment should not stop and start again (no */).

Otherwise,

Reviewed-by: Peter Crosthwaite <address@hidden>

Regards,
Peter

> +    /* is set to 0. Block protection is not supported */
> +    { INFO("at25128a-nonjedec", 0x0,     0,         1, 131072, WR_1) },
> +    { INFO("at25256a-nonjedec", 0x0,     0,         1, 262144, WR_1) },
> +
>      /* EON -- en25xxx */
>      { INFO("en25f32",     0x1c3116,      0,  64 << 10,  64, ER_4K) },
>      { INFO("en25p32",     0x1c2016,      0,  64 << 10,  64, 0) },
> --
> 2.5.0
>
>