|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 02/10] virtio: move allocation to virtqueue_pop/vring_pop |
Date: | Tue, 19 Jan 2016 14:16:22 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 19/01/2016 13:22, Cornelia Huck wrote: > > The patch is pretty large, but changes to each device are testable > > more or less independently. Splitting it would mostly add churn. > > Would it help to add a no-frills virtqueue_pop() version that simply > allocates the base VirtQueueElement and use a _size() variant for those > callers that want an extended structure? Not too much, the churn mostly comes from the VQE* being returned from virtqueue_pop, rather than passed to it. > assert(sz >= sizeof(VirtQueueElement)); Good idea. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |