[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/5] acpi: Remove unused acpi_table_add_builtin(
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH 7/5] acpi: Remove unused acpi_table_add_builtin() function |
Date: |
Tue, 26 Jan 2016 18:27:16 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
On 01/26/16 15:59, Eduardo Habkost wrote:
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> Additional code removal.
> ---
> hw/acpi/core.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/hw/acpi/core.c b/hw/acpi/core.c
> index 21e113d..c2a5383 100644
> --- a/hw/acpi/core.c
> +++ b/hw/acpi/core.c
> @@ -309,14 +309,6 @@ out:
> error_propagate(errp, err);
> }
>
> -static bool acpi_table_builtin = false;
> -
> -void acpi_table_add_builtin(const QemuOpts *opts, Error **errp)
> -{
> - acpi_table_builtin = true;
> - acpi_table_add(opts, errp);
> -}
> -
> unsigned acpi_table_len(void *current)
> {
> struct acpi_table_header *hdr = current - sizeof(hdr->_length);
> @@ -332,7 +324,7 @@ void *acpi_table_hdr(void *h)
>
> uint8_t *acpi_table_first(void)
> {
> - if (acpi_table_builtin || !acpi_tables) {
> + if (!acpi_tables) {
> return NULL;
> }
> return acpi_table_hdr(acpi_tables + ACPI_TABLE_PFX_SIZE);
>
Reviewed-by: Laszlo Ersek <address@hidden>
- [Qemu-devel] [PATCH v2 3/5] ich9: Remove enable_tco arguments from init functions, (continued)
- [Qemu-devel] [PATCH v2 3/5] ich9: Remove enable_tco arguments from init functions, Eduardo Habkost, 2016/01/23
- [Qemu-devel] [PATCH v2 4/5] q35: Remove unused q35-acpi-dsdt.aml file, Eduardo Habkost, 2016/01/23
- [Qemu-devel] [PATCH v2 5/5] q35: No need to check gigabyte_align, Eduardo Habkost, 2016/01/23
- Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused compat code, Laszlo Ersek, 2016/01/25
- Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused compat code, Igor Mammedov, 2016/01/26
- [Qemu-devel] [PATCH 6/5] pc: Remove unused pc_acpi_init() function, Eduardo Habkost, 2016/01/26
- [Qemu-devel] [PATCH 7/5] acpi: Remove unused acpi_table_add_builtin() function, Eduardo Habkost, 2016/01/26